First of all:
Sorry if I had misspellings. I'm from Paraguay and I am using Google Translate.
This may seem a little silly, and I'm a perfectionist and like any good developer and designer, do not want bugs in my projects. I am in the process of learning and hope to learn much with you
I have seen media player applications that allow the user to quickly and repeatedly press the play/stop button without killing the application, and that this is still functioning properly, so I read about Services, AsyncTask and Thread. Not only to play the sound in the background but also to not kill my application with UI errors. I have many questions yet.
I wonder if I'm on a good path using the following resource (found online), but I have tried and the application dies when I press for several times the play/stop buttom or sometimes simply not play the song.
package com.myaudioservice.app;
import android.app.Service;
import android.content.Intent;
import android.media.AudioManager;
import android.media.MediaPlayer;
import android.os.AsyncTask;
import android.os.Binder;
import android.os.IBinder;
/**
* Service to serv MediaPlayer in background
*
* #author Eugeny Pozharsky
*/
public class PlayerService extends Service {
private final IBinder mBinder = new LocalBinder();
private MediaPlayer mediaPlayer;
private PlayerCallback callback;
public class LocalBinder extends Binder {
PlayerService getService() {
return PlayerService.this;
}
}
#Override
public IBinder onBind(Intent intent) {
return mBinder;
}
/**
* Kill MediaPlayer to release resources
*/
#Override
public void onDestroy() {
super.onDestroy();
if (mediaPlayer != null) {
stop();
mediaPlayer.release();
}
}
/**
* Starts playing stream.
* Note that we just start media player and do not obtain real URL of the stream.
* So, URL that will be redirected by server will not work. To make such URLs works, adding
* algorithm to obtain the real URL (f.e., create HttpConnection, connect to the server and
* get real URL from connection).
*
* #param url String with URL of a server to connect
*/
public void start(String url) {
if (mediaPlayer == null) {
mediaPlayer = new MediaPlayer();
}
if (isPlaying()) {
mediaPlayer.stop();
mediaPlayer.reset();
}
new Player().execute(url);
Log.e("PlayerService", "start()");
}
/**
* Stops playing of the stream.
*/
public void stop() {
// stopping MediaPlayer in separate thread because it can take a time
new Thread(new Runnable() {
#Override
public void run() {
if (mediaPlayer != null) {
if (mediaPlayer.isPlaying()) {
mediaPlayer.stop();
}
//mediaPlayer.release();
//mediaPlayer = null;
}
}
}).start();
if (callback != null) {
callback.onStopped();
}
Log.e("PlayerService", "stop()");
}
/**
* Is stream playing?
*
* #return true or false
*/
public Boolean isPlaying() {
return mediaPlayer != null && mediaPlayer.isPlaying();
}
public void setCallback(PlayerCallback callback) {
this.callback = callback;
}
/**
* Background task to start MediaPlayer. It is used because starting playing of remote stream may
* take long time and we must not block UI thread.
* Also, this approach allows to cancel starting process (not implemented in current version)
*/
private class Player extends AsyncTask<String, Void, Void> {
/**
* This function called in UI thread and we callback to activity to update UI elements
*/
#Override
protected void onPreExecute() {
super.onPreExecute();
if (callback != null) {
callback.onPreStart();
}
}
/**
* This function called in UI thread and we callback to activity to update UI elements
*/
#Override
protected void onPostExecute(Void aVoid) {
super.onPostExecute(aVoid);
if (mediaPlayer == null || !mediaPlayer.isPlaying()) {
// Start MediaPlayer fail.
if (callback != null) {
callback.onStartFailed();
}
} else {
if (callback != null) {
callback.onStarted();
}
}
}
/**
* This function called from separate thread and we do long-time operation in it
*
* #param strings params
* #return null
*/
#Override
protected Void doInBackground(String... strings) {
//mediaPlayer = new MediaPlayer();
try {
mediaPlayer.setDataSource(strings[0]);
mediaPlayer.setAudioStreamType(AudioManager.STREAM_MUSIC);
mediaPlayer.prepare();
mediaPlayer.start();
} catch (Exception e) {
if (mediaPlayer != null) {
mediaPlayer.release();
}
mediaPlayer = null;
}
return null;
}
}
}
I wonder if I should cancel my AsyncTask process at any time or if I should add/modify something that my application will not die. How should I do?
Someone can guide me?
I usually get the error (if it appears) in my logcast it is as follows:
java.lang.IllegalStateException: Cannot execute task: the task has already been executed (a task can be executed only once)
For the Play/Stop button:
btn_control.setOnClickListener(new View.OnClickListener() {
#Override
public void onClick(View v) {
control((!ON_PLAY) ? 1 : 0);
}
});
private void control(int est) {
if(est==1){
if (!hayConexion()) {
Toast.makeText(Principal.this, getString(R.string.error_conexion_txt), Toast.LENGTH_SHORT).show();
} else {
if (mBound) {
mService.start();
ON_PLAY = true;
}
}
}else if(est==0) {
if (mBound) {
mService.stop();
ON_PLAY = false;
}
}
}
EDIT:
Logcat:
09-08 03:13:08.333 32438-32474/com.myaudioservice.app V/MediaPlayer-JNI﹕ native_setup
09-08 03:13:08.333 32438-32474/com.myaudioservice.app V/MediaPlayer﹕ constructor
09-08 03:13:08.343 32438-32474/com.myaudioservice.app V/MediaPlayer﹕ setListener
09-08 03:13:08.343 32438-32474/com.myaudioservice.app I/MediaPlayer﹕ path is null
09-08 03:13:08.343 32438-32474/com.myaudioservice.app D/MediaPlayer﹕ setDataSource IOException happend :
java.io.FileNotFoundException: No content provider: rtsp://ip/folder/file.stream
at android.content.ContentResolver.openTypedAssetFileDescriptor(ContentResolver.java:1053)
at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:907)
at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:834)
at android.media.MediaPlayer.setDataSource(MediaPlayer.java:988)
at android.media.MediaPlayer.setDataSource(MediaPlayer.java:942)
at com.myaudioservice.app.PlayerService$Player.doInBackground(PlayerService.java:156)
at com.myaudioservice.app.PlayerService$Player.doInBackground(PlayerService.java:130)
at android.os.AsyncTask$2.call(AsyncTask.java:288)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
09-08 03:13:08.343 32438-32474/com.myaudioservice.app D/MediaPlayer﹕ Couldn't open file on client side, trying server side
09-08 03:13:08.353 32438-32474/com.myaudioservice.app V/MediaPlayer-JNI﹕ setAudioStreamType: 3
09-08 03:13:08.353 32438-32474/com.myaudioservice.app V/MediaPlayer﹕ MediaPlayer::setAudioStreamType
09-08 03:13:08.353 32438-32474/com.myaudioservice.app D/com.myaudioservice.app.PlayerService﹕ Preparing: rtsp://ip/folder/file.stream
09-08 03:13:08.353 32438-32474/com.myaudioservice.app V/MediaPlayer﹕ setVideoSurfaceTexture
09-08 03:13:08.353 32438-32474/com.myaudioservice.app V/MediaPlayer﹕ prepare
09-08 03:13:09.384 32438-32438/com.myaudioservice.app E/PlayerService﹕ stop()
09-08 03:13:09.394 32438-32495/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 03:13:09.394 32438-32495/com.myaudioservice.app V/MediaPlayer-JNI﹕ release
09-08 03:13:09.394 32438-32495/com.myaudioservice.app V/MediaPlayer﹕ setListener
09-08 03:13:09.394 32438-32495/com.myaudioservice.app V/MediaPlayer﹕ disconnect
09-08 03:13:09.544 32438-32438/com.myaudioservice.app D/AndroidRuntime﹕ Shutting down VM
09-08 03:13:09.544 32438-32438/com.myaudioservice.app W/dalvikvm﹕ threadid=1: thread exiting with uncaught exception (group=0x4193eda0)
09-08 03:13:09.544 32438-32438/com.myaudioservice.app E/AndroidRuntime﹕ FATAL EXCEPTION: main
Process: com.myaudioservice.app, PID: 32438
java.lang.IllegalStateException
at android.media.MediaPlayer.isPlaying(Native Method)
at com.myaudioservice.app.PlayerService.reproduciendo(PlayerService.java:118)
at com.myaudioservice.app.PlayerService.start(PlayerService.java:84)
at com.myaudioservice.app.MainActivity.control(MainActivity.java:298)
at com.myaudioservice.app.MainActivity.access$100(MainActivity.java:38)
at com.myaudioservice.app.MainActivity$1.onClick(MainActivity.java:173)
at android.view.View.performClick(View.java:4640)
at android.view.View$PerformClick.run(View.java:19425)
at android.os.Handler.handleCallback(Handler.java:733)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:146)
at android.app.ActivityThread.main(ActivityThread.java:5593)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1283)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1099)
at dalvik.system.NativeStart.main(Native Method)
NEW LOGCAT:
09-08 14:49:24.360 9651-9651/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 14:49:24.360 9651-9651/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 14:49:24.390 9651-9651/com.myaudioservice.app E/PlayerService﹕ start()
09-08 14:49:24.480 9651-10534/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 14:49:24.480 9651-10534/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 14:49:24.480 9651-10534/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 14:49:24.480 9651-10534/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 14:49:24.490 9651-9651/com.myaudioservice.app E/PlayerService﹕ stop()
09-08 14:49:24.620 9651-9651/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 14:49:24.620 9651-9651/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 14:49:24.650 9651-9651/com.myaudioservice.app E/PlayerService﹕ start()
09-08 14:49:24.770 9651-10535/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 14:49:24.770 9651-10535/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 14:49:24.770 9651-10535/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 14:49:24.770 9651-10535/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 14:49:24.780 9651-9651/com.myaudioservice.app E/PlayerService﹕ stop()
09-08 14:49:24.890 9651-9651/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 14:49:24.890 9651-9651/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 14:49:24.910 9651-9651/com.myaudioservice.app E/PlayerService﹕ start()
09-08 14:49:25.021 9651-10540/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 14:49:25.031 9651-10540/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 14:49:25.031 9651-10540/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 14:49:25.031 9651-10540/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 14:49:25.041 9651-9651/com.myaudioservice.app E/PlayerService﹕ stop()
09-08 14:49:25.151 9651-9651/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 14:49:25.151 9651-9651/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 14:49:25.181 9651-9651/com.myaudioservice.app E/PlayerService﹕ start()
EDIT 2:
-----------------------------------------------------------------------
I thought I already had it until I got an bug (just at the end of my service) :(
Edited PlayerService class
package com.myaudioservice.app;
import android.app.Service;
import android.content.Intent;
import android.media.AudioManager;
import android.media.MediaPlayer;
import android.os.Binder;
import android.os.IBinder;
import android.util.Log;
public class PlayerService extends Service implements MediaPlayer.OnPreparedListener, MediaPlayer.OnInfoListener, MediaPlayer.OnCompletionListener {
private static final String LOG_TAG = PlayerService.class.getName();
private String URL_STREAM = "rtsp://domain/folder/file.stream";
private MediaPlayer mMediaPlayer = null;
private PlayerCallback callback;
private final IBinder mBinder = new LocalBinder();
public class LocalBinder extends Binder {
PlayerService getService() {
return PlayerService.this;
}
}
#Override
public IBinder onBind(Intent intent) {
return mBinder;
}
#Override
public void onDestroy(){
if (mMediaPlayer != null) {
stop();
mMediaPlayer.release();
mMediaPlayer = null;
}
}
/**
* Starts playing stream.
* Note that we just start media player and do not obtain real URL of the stream.
* So, URL that will be redirected by server will not work. To make such URLs works, adding
* algorithm to obtain the real URL (f.e., create HttpConnection, connect to the server and
* get real URL from connection).
*
* //#param url String with URL of a server to connect
*/
public void start() {
if (mMediaPlayer == null) mMediaPlayer = new MediaPlayer();
if (isPlaying()) {
mMediaPlayer.stop();
mMediaPlayer.reset();
}
try {
mMediaPlayer.setDataSource(URL_STREAM);
mMediaPlayer.setAudioStreamType(AudioManager.STREAM_MUSIC);
if (callback != null) callback.onPreStart();
Log.e(LOG_TAG, "Preparando: " + URL_STREAM);
mMediaPlayer.prepareAsync();
} catch (Exception e) {
if (mMediaPlayer != null) {
mMediaPlayer.reset();
}
Log.e(LOG_TAG, e.toString());
//mMediaPlayer = null;
}
mMediaPlayer.setOnPreparedListener(this);
mMediaPlayer.setOnInfoListener(this);
mMediaPlayer.setOnCompletionListener(this);
}
#Override
public void onPrepared(MediaPlayer mp) {
mp.start();
Log.e(LOG_TAG, "start()");
}
#Override
public boolean onInfo(MediaPlayer mp, int what, int extra) {
switch (what) {
case MediaPlayer.MEDIA_ERROR_IO:
case MediaPlayer.MEDIA_ERROR_MALFORMED:
case MediaPlayer.MEDIA_ERROR_NOT_VALID_FOR_PROGRESSIVE_PLAYBACK:
case MediaPlayer.MEDIA_ERROR_SERVER_DIED:
case MediaPlayer.MEDIA_ERROR_TIMED_OUT:
case MediaPlayer.MEDIA_ERROR_UNSUPPORTED:
if (mMediaPlayer == null || !mMediaPlayer.isPlaying()) {
// Start MediaPlayer fail.
if (callback != null) callback.onStartFailed();
}
Log.e(LOG_TAG, "Error");
break;
case MediaPlayer.MEDIA_INFO_BUFFERING_START:
if (callback != null) callback.onStarted();
Log.e(LOG_TAG, "Almacenando en búfer");
break;
case MediaPlayer.MEDIA_INFO_BUFFERING_END:
if (callback != null) callback.onPlaying();
Log.e(LOG_TAG, "Reproduciendo");
break;
}
return false;
}
#Override
public void onCompletion(MediaPlayer mp) {
Log.e(LOG_TAG, "Reproducción finalizada");
stop();
}
/**
* Stops playing of the stream.
*/
public void stop() {
// stopping MediaPlayer in separate thread because it can take a time
new Thread(new Runnable() {
#Override
public void run() {
if (mMediaPlayer != null) {
if (mMediaPlayer.isPlaying()) mMediaPlayer.stop(); // I get the error here when I destroy the Service quickly
mMediaPlayer.reset();
}
}
}).start();
if (callback != null) callback.onStopped();
Log.e(LOG_TAG, "stop()");
}
/**
* Is stream playing?
*
* #return true or false
*/
public Boolean isPlaying() {
return mMediaPlayer != null && mMediaPlayer.isPlaying();
}
public void setCallback(PlayerCallback callback) {
this.callback = callback;
}
}
Logcat:
09-08 19:15:39.578 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 19:15:39.578 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:39.578 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ setAudioStreamType: 3
09-08 19:15:39.578 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ MediaPlayer::setAudioStreamType
09-08 19:15:39.578 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ Preparando: rtsp://domain/folder/file.stream
09-08 19:15:39.578 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ setVideoSurfaceTexture
09-08 19:15:39.578 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ prepareAsync
09-08 19:15:39.678 27582-31945/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:39.678 27582-31945/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 19:15:39.678 27582-31945/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 19:15:39.678 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=1, ext1=0, ext2=0
09-08 19:15:39.688 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(1, 0, 0) callback on disconnected mediaplayer
09-08 19:15:39.688 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=8, ext1=0, ext2=0
09-08 19:15:39.688 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(8, 0, 0) callback on disconnected mediaplayer
09-08 19:15:39.688 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ stop()
09-08 19:15:39.798 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 19:15:39.798 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:39.808 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ setAudioStreamType: 3
09-08 19:15:39.808 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ MediaPlayer::setAudioStreamType
09-08 19:15:39.808 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ Preparando: rtsp://domain/folder/file.stream
09-08 19:15:39.808 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ setVideoSurfaceTexture
09-08 19:15:39.808 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ prepareAsync
09-08 19:15:39.938 27582-31952/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:39.938 27582-31952/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 19:15:39.938 27582-31952/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 19:15:39.938 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=1, ext1=0, ext2=0
09-08 19:15:39.938 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(1, 0, 0) callback on disconnected mediaplayer
09-08 19:15:39.938 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=8, ext1=0, ext2=0
09-08 19:15:39.938 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(8, 0, 0) callback on disconnected mediaplayer
09-08 19:15:39.948 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ stop()
09-08 19:15:40.069 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 19:15:40.069 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:40.079 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ setAudioStreamType: 3
09-08 19:15:40.079 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ MediaPlayer::setAudioStreamType
09-08 19:15:40.079 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ Preparando: rtsp://domain/folder/file.stream
09-08 19:15:40.079 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ setVideoSurfaceTexture
09-08 19:15:40.079 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ prepareAsync
09-08 19:15:40.179 27582-31957/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:40.179 27582-31957/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 19:15:40.179 27582-31957/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 19:15:40.179 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=1, ext1=0, ext2=0
09-08 19:15:40.189 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(1, 0, 0) callback on disconnected mediaplayer
09-08 19:15:40.189 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=8, ext1=0, ext2=0
09-08 19:15:40.189 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(8, 0, 0) callback on disconnected mediaplayer
09-08 19:15:40.189 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ stop()
09-08 19:15:40.289 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 19:15:40.289 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:40.299 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ setAudioStreamType: 3
09-08 19:15:40.299 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ MediaPlayer::setAudioStreamType
09-08 19:15:40.299 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ Preparando: rtsp://domain/folder/file.stream
09-08 19:15:40.299 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ setVideoSurfaceTexture
09-08 19:15:40.299 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ prepareAsync
09-08 19:15:40.429 27582-31966/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:40.429 27582-31966/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 19:15:40.429 27582-31966/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 19:15:40.429 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=1, ext1=0, ext2=0
09-08 19:15:40.429 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(1, 0, 0) callback on disconnected mediaplayer
09-08 19:15:40.429 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ stop()
09-08 19:15:40.429 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=8, ext1=0, ext2=0
09-08 19:15:40.429 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(8, 0, 0) callback on disconnected mediaplayer
09-08 19:15:40.549 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ isPlaying: no active player
09-08 19:15:40.549 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:40.559 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ setAudioStreamType: 3
09-08 19:15:40.559 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ MediaPlayer::setAudioStreamType
09-08 19:15:40.559 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ Preparando: rtsp://domain/folder/file.stream
09-08 19:15:40.559 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ setVideoSurfaceTexture
09-08 19:15:40.559 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ prepareAsync
09-08 19:15:40.659 27582-31972/com.myaudioservice.app V/MediaPlayer-JNI﹕ isPlaying: 0
09-08 19:15:40.659 27582-31972/com.myaudioservice.app V/MediaPlayer-JNI﹕ reset
09-08 19:15:40.659 27582-31972/com.myaudioservice.app V/MediaPlayer﹕ reset
09-08 19:15:40.659 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=1, ext1=0, ext2=0
09-08 19:15:40.659 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(1, 0, 0) callback on disconnected mediaplayer
09-08 19:15:40.659 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ message received msg=8, ext1=0, ext2=0
09-08 19:15:40.659 27582-27596/com.myaudioservice.app V/MediaPlayer﹕ notify(8, 0, 0) callback on disconnected mediaplayer
09-08 19:15:40.669 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ stop()
09-08 19:16:01.281 27582-27582/com.myaudioservice.app D/AbsListView﹕ onDetachedFromWindow
09-08 19:16:01.311 27582-27582/com.myaudioservice.app E/com.myaudioservice.app.PlayerService﹕ stop()
09-08 19:16:01.311 27582-27582/com.myaudioservice.app V/MediaPlayer-JNI﹕ release
09-08 19:16:01.311 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ setListener
09-08 19:16:01.311 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ disconnect
09-08 19:16:01.311 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ destructor
09-08 19:16:01.311 27582-32148/com.myaudioservice.app W/dalvikvm﹕ threadid=14: thread exiting with uncaught exception (group=0x4193eda0)
09-08 19:16:01.311 27582-27582/com.myaudioservice.app V/MediaPlayer﹕ disconnect
09-08 19:16:01.321 27582-32148/com.myaudioservice.app E/AndroidRuntime﹕ FATAL EXCEPTION: Thread-15992
Process: com.myaudioservice.app, PID: 27582
java.lang.IllegalStateException
at android.media.MediaPlayer.isPlaying(Native Method)
at com.myaudioservice.app.PlayerService$1.run(PlayerService.java:129)
at java.lang.Thread.run(Thread.java:841)
In documentation you can read that MediaPlayer.isPlaying() throws IllegalStateException if the internal player engine has not been initialized or has been released.
This code is not thread safe which is probably the reason of this exception (thread call release() and before mediaPlayer is set to null app invoking isPlaying() on released mediaPlayer). You need to add some synchronization to make it work (or use async methods form MediaPlayer).
Ok , I think I finally got what I wanted .
I do not know if I should mark the #KamilW response as the correct because it does have absolutely right but I will answer my question with the right code (or at least think is right) it can be useful to someone else.
My final code:
package com.myaudioservice.app;
import android.app.Service;
import android.content.Intent;
import android.media.AudioManager;
import android.media.MediaPlayer;
import android.os.Binder;
import android.os.IBinder;
import android.util.Log;
public class PlayerService extends Service implements MediaPlayer.OnPreparedListener, MediaPlayer.OnInfoListener, MediaPlayer.OnErrorListener, MediaPlayer.OnCompletionListener {
private static final String LOG_TAG = PlayerService.class.getName();
private String URL_STREAM = "rtsp://domain/folder/file.stream";
private MediaPlayer mMediaPlayer = null;
private PlayerCallback callback;
private final IBinder mBinder = new LocalBinder();
public class LocalBinder extends Binder {
PlayerService getService() {
return PlayerService.this;
}
}
#Override
public IBinder onBind(Intent intent) {
return mBinder;
}
#Override
public void onDestroy(){
if (mMediaPlayer != null) {
mMediaPlayer.release();
mMediaPlayer = null;
}
}
/**
* Starts playing stream.
* Note that we just start media player and do not obtain real URL of the stream.
* So, URL that will be redirected by server will not work. To make such URLs works, adding
* algorithm to obtain the real URL (f.e., create HttpConnection, connect to the server and
* get real URL from connection).
*
* //#param url String with URL of a server to connect
*/
public void start() {
if (mMediaPlayer == null) mMediaPlayer = new MediaPlayer();
if (isPlaying()) {
mMediaPlayer.stop();
mMediaPlayer.reset();
}
try {
mMediaPlayer.setDataSource(URL_STREAM);
mMediaPlayer.setAudioStreamType(AudioManager.STREAM_MUSIC);
if (callback != null) callback.onPreStart();
Log.e(LOG_TAG, "Preparando: " + URL_STREAM);
mMediaPlayer.prepareAsync();
} catch (Exception e) {
if (mMediaPlayer != null) {
mMediaPlayer.reset();
}
if (callback != null) callback.onStartFailed();
Log.e(LOG_TAG, e.toString());
//mMediaPlayer = null;
}
mMediaPlayer.setOnPreparedListener(this);
mMediaPlayer.setOnInfoListener(this);
mMediaPlayer.setOnErrorListener(this);
mMediaPlayer.setOnCompletionListener(this);
}
#Override
public void onPrepared(MediaPlayer mp) {
mp.start();
Log.e(LOG_TAG, "start()");
}
#Override
public boolean onInfo(MediaPlayer mp, int what, int extra) {
switch (what) {
case MediaPlayer.MEDIA_INFO_BUFFERING_START:
if (callback != null) callback.onStarted();
Log.e(LOG_TAG, "Almacenando en búfer");
break;
case MediaPlayer.MEDIA_INFO_BUFFERING_END:
if (callback != null) callback.onPlaying();
Log.e(LOG_TAG, "Reproduciendo");
break;
}
return false;
}
#Override
public void onCompletion(MediaPlayer mp) {
Log.e(LOG_TAG, "Reproducción finalizada");
stop();
}
/**
* Stops playing of the stream.
*/
public void stop() {
// stopping MediaPlayer in separate thread because it can take a time
new Thread(new Runnable() {
#Override
public void run() {
if (mMediaPlayer != null) {
if (mMediaPlayer.isPlaying()) mMediaPlayer.stop();
mMediaPlayer.reset();
}
}
}).start();
if (callback != null) callback.onStopped();
Log.e(LOG_TAG, "stop()");
}
/**
* Is stream playing?
*
* #return true or false
*/
public Boolean isPlaying() {
return mMediaPlayer != null && mMediaPlayer.isPlaying();
}
public void setCallback(PlayerCallback callback) {
this.callback = callback;
}
#Override
public boolean onError(MediaPlayer mp, int what, int extra){
if(what == MediaPlayer.MEDIA_ERROR_UNKNOWN ||
what == MediaPlayer.MEDIA_ERROR_SERVER_DIED ||
extra == MediaPlayer.MEDIA_ERROR_IO ||
extra == MediaPlayer.MEDIA_ERROR_MALFORMED ||
extra == MediaPlayer.MEDIA_ERROR_UNSUPPORTED ||
extra == MediaPlayer.MEDIA_ERROR_TIMED_OUT ||
extra == MediaPlayer.MEDIA_ERROR_NOT_VALID_FOR_PROGRESSIVE_PLAYBACK){
stop();
if (callback != null) callback.onStartFailed();
}
return true;// Si hay error, no es necesario llamar a onCompletionListener, por eso: true
}
}
I would also like to be inspected by an expert to tell me what I need to improve in the code (if not too much to ask). Thak You.
Related
I have edit text in listview and when a edit text is focus it's reload/refresh the listview.
public class MyActivity extends AppCompatActivity {
#Override
protected void onCreate(#Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
ListView lv = new ListView(getApplicationContext());
setContentView(lv);
lv.setAdapter(new MyAdapter(getApplicationContext()));
}
}
and :
public class MyAdapter extends BaseAdapter {
private Context context;
public ArrayList myItems = new ArrayList();
public MyAdapter(Context context) {
this.context = context;
for (int i = 0; i < 20; i++) {
LauncherActivity.ListItem listItem = new LauncherActivity.ListItem();
myItems.add(listItem);
}
}
#NonNull
#Override
public View getView(int position, #Nullable View convertView, #NonNull ViewGroup parent) {
convertView = LayoutInflater.from(context).inflate(R.layout.temp, null);
return convertView;
}
}
Why it's produce this ?
And How to prevent this ?
09-08 19:38:59.913 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: finishComposingText on inactive InputConnection
09-08 19:39:00.044 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: getExtractedText on inactive InputConnection
09-08 19:39:00.058 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: getTextBeforeCursor on inactive InputConnection
09-08 19:39:00.089 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: getExtractedText on inactive InputConnection
09-08 19:39:00.101 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: getTextBeforeCursor on inactive InputConnection
09-08 19:39:00.167 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: finishComposingText on inactive InputConnection
09-08 19:39:00.267 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: getExtractedText on inactive InputConnection
09-08 19:39:00.281 14702-14702/com.infinity.passwordmanager W/IInputConnectionWrapper: getTextBeforeCursor on inactive InputConnection
To Log or maybe Toast what happens before or after the view click, implement
LoaderManager.LoaderCallbacks<Cursor>
on your
MyActivity
But first you'll have to extend ListActivity, which isn't an issue since your whole Activity is occupied by a ListView.
This will get you closer to what's wrong since we are limited by the amount of information your Log is posting
https://developer.android.com/guide/topics/ui/layout/listview#java
I have a media player which plays mp3 from an URL. When I play a song and press the back button, the application gives an error. I used prepareAsync();.
I am new, so sorry if you cannot understand me well.
Here is my play function and ondestroy function. Thanks.
public void playSong(final int naatindex){
// Play song
tv = (TextView) this.findViewById(R.id.mywidget);
try {
mp.reset();
mp.setDataSource(naatpaths[naatindex]);
Log.w("Play Song", "CS"+naatindex);
tv.setText("Buffering Please Wait....!");
songCurrentDurationLabel.setVisibility(View.INVISIBLE);
tv.setSelected(true);
songTotalDurationLabel.setVisibility(View.INVISIBLE);
mp.prepareAsync();
mp.setOnPreparedListener(new OnPreparedListener(){
#Override
public void onPrepared(MediaPlayer mp){
songCurrentDurationLabel.setVisibility(View.VISIBLE);
songTotalDurationLabel.setVisibility(View.VISIBLE);
mp.start();
tv.setText(naattitles[naatindex]);
// Changing Button Image to pause image
btnPlay.setImageResource(R.drawable.btn_pause);
// set Progress bar values
songProgressBar.setProgress(0);
songProgressBar.setMax(100);
// Updating progress bar
updateProgressBar();
}
});
mp.setOnErrorListener(new OnErrorListener() {
public boolean onError(MediaPlayer mp, int what, int extra) {
Log.w("Unable to Play", "CS"+naatindex);
playSong(currentSongIndex+1);
return false;
}
});
// Set focus to the textview
} catch (IllegalArgumentException e) {
e.printStackTrace();
} catch (IllegalStateException e) {
e.printStackTrace();
} catch (IOException e) {
e.printStackTrace();
}
}
#Override
public void onDestroy(){
mp.release();
mp = null;
super.onDestroy();
}
here is my log error
01-10 16:16:40.339: W/dalvikvm(26539): threadid=1: thread exiting with uncaught exception (group=0x416282a0)
01-10 16:16:40.344: E/AndroidRuntime(26539): FATAL EXCEPTION: main
01-10 16:16:40.344: E/AndroidRuntime(26539): java.lang.NullPointerException
01-10 16:16:40.344: E/AndroidRuntime(26539): at com.maulantariqjameel.bayyan.media_player$1.run(media_player.java:5032)
01-10 16:16:40.344: E/AndroidRuntime(26539): at android.os.Handler.handleCallback(Handler.java:615)
01-10 16:16:40.344: E/AndroidRuntime(26539): at android.os.Handler.dispatchMessage(Handler.java:92)
01-10 16:16:40.344: E/AndroidRuntime(26539): at android.os.Looper.loop(Looper.java:137)
01-10 16:16:40.344: E/AndroidRuntime(26539): at android.app.ActivityThread.main(ActivityThread.java:4921)
01-10 16:16:40.344: E/AndroidRuntime(26539): at java.lang.reflect.Method.invokeNative(Native Method)
01-10 16:16:40.344: E/AndroidRuntime(26539): at java.lang.reflect.Method.invoke(Method.java:511)
01-10 16:16:40.344: E/AndroidRuntime(26539): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1038)
01-10 16:16:40.344: E/AndroidRuntime(26539): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:805)
01-10 16:16:40.344: E/AndroidRuntime(26539): at dalvik.system.NativeStart.main(Native Method)
#Override
protected void onDestroy() {
if (runnableObject != null)
myHandler.removeCallbacks(runnableObject );
super.onDestroy();
}
private void backPressed() {
if (mpAudioSdCard != null) {
mpAudioSdCard.stop();
mpAudioSdCard.release();
mpAudioSdCard = null;
}
}
try this it will work for me i think ur mistake is ur call super.onDestroy(); first
private void releaseMediaPlayer() {
if (mp!= null) {
if(mp.isPlaying()) {
mp.stop();
}
mp.release();
mp= null;
}
}
#Override
protected void onDestroy() {
super.onDestroy();
releaseMediaPlayer();
}
OR
private void releaseMediaPlayer() {
if (mp!= null) {
if(mp.isPlaying()) {
mp.stop();
}
mp.release();
mp= null;
}
}
#Override
public void onBackPressed() {
releaseMediaPlayer();
finish();
}
In onDestroy() there is no need to call this.finish() as the activity is already being finished. Remove that line and try again.
You should call super.onbackpressed() before release..try this code
#Override
public void onBackPressed() {
super.onBackPressed();
System.out.println("onBackPressed() called");
releaseMediaPlayer();
}
Looking at the logs, it appears that the error is happening inside a Runnable that you have posted to a Handler. I'm guessing that you posted it using postDelayed() to update the UI or something based on the MediaPlayer state at a regular interval. Am I right? You are setting mp to null in the onDestroy() but the Runnable keeps running and tries to access it, causing the NullPointerException.
To fix this, you need to clear the handler's queue of pending Runnables in your onDestroy(), like this:
mHandler.removeCallbacks(null);
Even better is to do it in your onPause() and then restart it in onResume()
I was having some problem with the session when trying to integrate Facebook with Android. I followed Tutorial. Here is my codes:
public class EventDetail extends Fragment {
private UiLifecycleHelper uiHelper;
private static final List<String> PERMISSIONS = Arrays.asList("publish_actions");
private static String message = "Sample status posted from android app";
#Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
uiHelper = new UiLifecycleHelper(getActivity(), statusCallback);
uiHelper.onCreate(savedInstanceState);
ivFacebookShare = (ImageView) eventDetail.findViewById(R.id.ivFacebookShare);
ivFacebookShare.setOnClickListener(new OnClickListener(){
public void onClick(View v){
postStatusMessage();
}
});
return eventDetail;
}
private Session.StatusCallback statusCallback = new Session.StatusCallback() {
public void call(Session session, SessionState state, Exception exception) {
onSessionStateChange(session, state, exception);
}
};
private void onSessionStateChange(Session session, SessionState state, Exception exception) {
if (state.isOpened()) {
Log.i("TAG", "Logged in...");
} else if (state.isClosed()) {
Log.i("TAG", "Logged out...");
}
}
public void postStatusMessage() {
if (checkPermissions()) {
Request request = Request.newStatusUpdateRequest(
Session.getActiveSession(), message,
new Request.Callback() {
public void onCompleted(Response response) {
if (response.getError() == null)
Toast.makeText(getActivity(),
"Status updated successfully",
Toast.LENGTH_LONG).show();
}
});
request.executeAsync();
} else {
requestPermissions();
}
}
public boolean checkPermissions() {
Session s = Session.getActiveSession();
if (s != null) {
return s.getPermissions().contains("publish_actions");
} else
return false;
}
public void requestPermissions() {
Session s = Session.getActiveSession();
if (s != null)
s.requestNewPublishPermissions(new Session.NewPermissionsRequest(
this, PERMISSIONS));
}
#Override
public void onResume() {
super.onResume();
uiHelper.onResume();
}
#Override
public void onPause() {
super.onPause();
uiHelper.onPause();
}
#Override
public void onDestroy() {
super.onDestroy();
uiHelper.onDestroy();
}
#Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
super.onActivityResult(requestCode, resultCode, data);
uiHelper.onActivityResult(requestCode, resultCode, data);
}
#Override
public void onSaveInstanceState(Bundle savedState) {
super.onSaveInstanceState(savedState);
uiHelper.onSaveInstanceState(savedState);
}
}
However, I am getting the error message as stacktrace:
12-23 16:14:36.907: D/AndroidRuntime(22942): Shutting down VM
12-23 16:14:36.907: W/dalvikvm(22942): threadid=1: thread exiting with uncaught exception (group=0x40c561f8)
12-23 16:14:36.961: E/AndroidRuntime(22942): FATAL EXCEPTION: main
12-23 16:14:36.961: E/AndroidRuntime(22942): java.lang.UnsupportedOperationException: Session: an attempt was made to request new permissions for a session that is not currently open.
12-23 16:14:36.961: E/AndroidRuntime(22942): at com.facebook.Session.requestNewPermissions(Session.java:1257)
12-23 16:14:36.961: E/AndroidRuntime(22942): at com.facebook.Session.requestNewPublishPermissions(Session.java:595)
12-23 16:14:36.961: E/AndroidRuntime(22942): at nyp.edu.eneighbourhood.EventDetail.requestPermissions(EventDetail.java:280)
12-23 16:14:36.961: E/AndroidRuntime(22942): at nyp.edu.eneighbourhood.EventDetail.postStatusMessage(EventDetail.java:265)
12-23 16:14:36.961: E/AndroidRuntime(22942): at nyp.edu.eneighbourhood.EventDetail$4.onClick(EventDetail.java:185)
12-23 16:14:36.961: E/AndroidRuntime(22942): at android.view.View.performClick(View.java:3620)
12-23 16:14:36.961: E/AndroidRuntime(22942): at android.view.View$PerformClick.run(View.java:14292)
12-23 16:14:36.961: E/AndroidRuntime(22942): at android.os.Handler.handleCallback(Handler.java:605)
12-23 16:14:36.961: E/AndroidRuntime(22942): at android.os.Handler.dispatchMessage(Handler.java:92)
12-23 16:14:36.961: E/AndroidRuntime(22942): at android.os.Looper.loop(Looper.java:137)
12-23 16:14:36.961: E/AndroidRuntime(22942): at android.app.ActivityThread.main(ActivityThread.java:4512)
12-23 16:14:36.961: E/AndroidRuntime(22942): at java.lang.reflect.Method.invokeNative(Native Method)
12-23 16:14:36.961: E/AndroidRuntime(22942): at java.lang.reflect.Method.invoke(Method.java:511)
12-23 16:14:36.961: E/AndroidRuntime(22942): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:982)
12-23 16:14:36.961: E/AndroidRuntime(22942): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:749)
12-23 16:14:36.961: E/AndroidRuntime(22942): at dalvik.system.NativeStart.main(Native Method)
12-23 16:14:44.594: I/Process(22942): Sending signal. PID: 22942 SIG: 9
Any guides? Thanks in advance.
The answer is exactly what the error states, you're requesting new permissions when the session hasn't been opened yet.
Are you calling Session.getActiveSession().open* (where open* is any of the open methods) anywhere?
In your code, you only check for session != null, but not s.isOpened(). You can only request more permissions on an open session.
I have the following code in android, but when I run it, it complains: unfortunately has stopped:
package com.example.trave;
import java.util.List;
import com.example.trave.data.NoteDataSource;
import com.example.trave.data.NoteItem;
import android.os.Bundle;
import android.app.Activity;
import android.util.Log;
import android.view.Menu;
public class MainActivity extends Activity {
private NoteDataSource dataSource;
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
dataSource = new NoteDataSource(this);
List<NoteItem> notes = dataSource.findAll();
NoteItem note = notes.get(0);
note.setText("Updated!");
dataSource.update(note);
notes = dataSource.findAll();
note = notes.get(0);
Log.i("NOTES", note.getKey() + ": " + note.getText());
}
#Override
public boolean onCreateOptionsMenu(Menu menu) {
// Inflate the menu; this adds items to the action bar if it is present.
getMenuInflater().inflate(R.menu.main, menu);
return true;
}
}
package com.example.trave.data;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.SortedSet;
import java.util.TreeSet;
import android.content.Context;
import android.content.SharedPreferences;
public class NoteDataSource {
private static final String PREFKEY = "notes";
private SharedPreferences notePrefs;
public NoteDataSource(Context context) {
notePrefs = context.getSharedPreferences(PREFKEY, Context.MODE_PRIVATE);
}
public List<NoteItem> findAll() {
Map<String, ?> notesMap = notePrefs.getAll();
SortedSet<String> keys = new TreeSet<String>(notesMap.keySet());
List<NoteItem> noteList = new ArrayList<NoteItem>();
for (String key : keys) {
NoteItem note = new NoteItem();
note.setKey(key);
note.setText((String)note.getKey());
noteList.add(note);
}
return noteList;
}
public boolean update(NoteItem note) {
SharedPreferences.Editor editor = notePrefs.edit();
editor.putString(note.getKey(), note.getText());
editor.commit();
return true;
}
public boolean remove(NoteItem note) {
if (notePrefs.contains(note.getKey())) {
SharedPreferences.Editor editor = notePrefs.edit();
editor.remove(note.getKey());
editor.commit();
}
return true;
}
}
package com.example.trave.data;
import android.annotation.SuppressLint;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.Locale;
public class NoteItem {
private String key;
private String text;
public String getKey() {
return key;
}
public void setKey(String key) {
this.key = key;
}
public String getText() {
return text;
}
public void setText(String text) {
this.text = text;
}
#SuppressLint("SimpleDateFormat")
public static NoteItem getNew() {
Locale locale = new Locale("en_US");
Locale.setDefault(locale);
String pattern = "yyyy-MM-dd HH:mm:ss Z";
SimpleDateFormat formatter = new SimpleDateFormat(pattern);
String key = formatter.format(new Date());
NoteItem note = new NoteItem();
note.setKey(key);
note.setText("");
return note;
}
}
what is the problem and how to fix it?
The logCat:
09-08 11:15:23.674: E/SurfaceFlinger(37): ro.sf.lcd_density must be defined as a build property
09-08 11:15:23.793: E/Trace(1552): error opening trace file: No such file or directory (2)
09-08 11:15:24.533: D/AndroidRuntime(1552): Shutting down VM
09-08 11:15:24.533: W/dalvikvm(1552): threadid=1: thread exiting with uncaught exception (group=0x40a71930)
09-08 11:15:24.543: E/AndroidRuntime(1552): FATAL EXCEPTION: main
09-08 11:15:24.543: E/AndroidRuntime(1552): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.trave/com.example.trave.MainActivity}: java.lang.IndexOutOfBoundsException: Invalid index 0, size is 0
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2180)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2230)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.ActivityThread.access$600(ActivityThread.java:141)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1234)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.os.Handler.dispatchMessage(Handler.java:99)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.os.Looper.loop(Looper.java:137)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.ActivityThread.main(ActivityThread.java:5041)
09-08 11:15:24.543: E/AndroidRuntime(1552): at java.lang.reflect.Method.invokeNative(Native Method)
09-08 11:15:24.543: E/AndroidRuntime(1552): at java.lang.reflect.Method.invoke(Method.java:511)
09-08 11:15:24.543: E/AndroidRuntime(1552): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:793)
09-08 11:15:24.543: E/AndroidRuntime(1552): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:560)
09-08 11:15:24.543: E/AndroidRuntime(1552): at dalvik.system.NativeStart.main(Native Method)
09-08 11:15:24.543: E/AndroidRuntime(1552): Caused by: java.lang.IndexOutOfBoundsException: Invalid index 0, size is 0
09-08 11:15:24.543: E/AndroidRuntime(1552): at java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:251)
09-08 11:15:24.543: E/AndroidRuntime(1552): at java.util.ArrayList.get(ArrayList.java:304)
09-08 11:15:24.543: E/AndroidRuntime(1552): at com.example.trave.MainActivity.onCreate(MainActivity.java:25)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.Activity.performCreate(Activity.java:5104)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1080)
09-08 11:15:24.543: E/AndroidRuntime(1552): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2144)
09-08 11:15:24.543: E/AndroidRuntime(1552): ... 11 more
09-08 11:15:24.552: W/ActivityManager(291): Force finishing activity com.example.trave/.MainActivity
09-08 11:15:24.562: W/WindowManager(291): Failure taking screenshot for (246x410) to layer 21015
you got IndexOutOfBoundsException at
List<NoteItem> notes = dataSource.findAll();
NoteItem note = notes.get(0);
or at
notes = dataSource.findAll();
note = notes.get(0);
because the list seems to be empty, you should check for size
List<NoteItem> notes = dataSource.findAll();
if (notes.size()>0)
NoteItem note = notes.get(0);
and check data you are providing to the lists
You get an IndexOutOfBoundsException because the NoteList is empty. Most likely at:
NoteItem note = notes.get(0);
in the onCreate method. You need to check for the empty result of NoteDataSource.findAll() like this:
List<NoteItem> notes = dataSource.findAll();
if(notes.isEmpty())
return; // Or whatever you must do in your App
else {
NoteItem note = notes.get(0);
// ... The rest of your onCreate code...
Additionally, in your NoteDataSource.update() and NoteDataSource.remove() please return the result of the commit() instead always true as of the contract: SharedPreferences.Editor.commit
otherwise there's not much sense in returning a boolean.
When i start my app and press stop or pause the android app will crash. It works fine if you press play first and then stop or pause. I searched on google and stackoverflow but i couldn't find much about it. I think the problem is because of a NullPointerException but since i'm new too java it doesn't tell me much about the problem
The code:
import android.app.Activity;
import android.media.AudioManager;
import android.media.MediaPlayer;
import android.net.Uri;
import android.os.Bundle;
import android.util.Log;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
public class myMain extends Activity implements
MediaPlayer.OnCompletionListener, MediaPlayer.OnPreparedListener,
MediaPlayer.OnErrorListener, MediaPlayer.OnBufferingUpdateListener, OnClickListener {
private String TAG = getClass().getSimpleName();
private MediaPlayer mp= null;
private Button play;
private Button pause;
private Button stop;
#Override
public void onCreate(Bundle icicle) {
super.onCreate(icicle);
setContentView(R.layout.main);
play = (Button) findViewById(R.id.play);
pause = (Button) findViewById(R.id.pause);
stop = (Button) findViewById(R.id.stop);
play.setOnClickListener(new View.OnClickListener() {
public void onClick(View view) {
play();
}
});
pause.setOnClickListener(new View.OnClickListener() {
public void onClick(View view){
pause();
}
});
stop.setOnClickListener(new View.OnClickListener() {
public void onClick(View view){
stop();
}
});
}
private void play() {
Uri myUri = Uri.parse("url");
try {
if (mp == null) {
this.mp = new MediaPlayer();
} else {
mp.stop();
mp.reset();
}
mp.setDataSource(this, myUri); // Go to Initialized state
mp.setAudioStreamType(AudioManager.STREAM_MUSIC);
mp.setOnPreparedListener(this);
mp.setOnBufferingUpdateListener(this);
mp.setOnErrorListener(this);
mp.prepareAsync();
Log.d(TAG, "LoadClip Done");
} catch (Throwable t) {
Log.d(TAG, t.toString());
}
}
public void onPrepared(MediaPlayer mp) {
Log.d(TAG, "Stream is prepared");
mp.start();
}
private void pause() {
mp.pause();
}
private void stop() {
mp.stop();
}
#Override
public void onDestroy() {
super.onDestroy();
stop();
}
public void onCompletion(MediaPlayer mp) {
stop();
}
public boolean onError(MediaPlayer mp, int what, int extra) {
StringBuilder sb = new StringBuilder();
sb.append("Media Player Error: ");
switch (what) {
case MediaPlayer.MEDIA_ERROR_NOT_VALID_FOR_PROGRESSIVE_PLAYBACK:
sb.append("Not Valid for Progressive Playback");
break;
case MediaPlayer.MEDIA_ERROR_SERVER_DIED:
sb.append("Server Died");
break;
case MediaPlayer.MEDIA_ERROR_UNKNOWN:
sb.append("Unknown");
break;
default:
sb.append(" Non standard (");
sb.append(what);
sb.append(")");
}
sb.append(" (" + what + ") ");
sb.append(extra);
Log.e(TAG, sb.toString());
return true;
}
public void onBufferingUpdate(MediaPlayer mp, int percent) {
Log.d(TAG, "PlayerService onBufferingUpdate : " + percent + "%");
}
public void onClick(View v) {
// TODO Auto-generated method stub
}
}
The errors:
02-11 20:45:43.837: D/AndroidRuntime(338): Shutting down VM
02-11 20:45:43.837: W/dalvikvm(338): threadid=1: thread exiting with uncaught exception (group=0x40015560)
02-11 20:45:43.857: E/AndroidRuntime(338): FATAL EXCEPTION: main
02-11 20:45:43.857: E/AndroidRuntime(338): java.lang.NullPointerException
02-11 20:45:43.857: E/AndroidRuntime(338): at wadio.media.internetradio.myMain.stop(myMain.java:95)
02-11 20:45:43.857: E/AndroidRuntime(338): at wadio.media.internetradio.myMain.access$2(myMain.java:94)
02-11 20:45:43.857: E/AndroidRuntime(338): at wadio.media.internetradio.myMain$3.onClick(myMain.java:55)
02-11 20:45:43.857: E/AndroidRuntime(338): at android.view.View.performClick(View.java:2485)
02-11 20:45:43.857: E/AndroidRuntime(338): at android.view.View$PerformClick.run(View.java:9080)
02-11 20:45:43.857: E/AndroidRuntime(338): at android.os.Handler.handleCallback(Handler.java:587)
02-11 20:45:43.857: E/AndroidRuntime(338): at android.os.Handler.dispatchMessage(Handler.java:92)
02-11 20:45:43.857: E/AndroidRuntime(338): at android.os.Looper.loop(Looper.java:123)
02-11 20:45:43.857: E/AndroidRuntime(338): at android.app.ActivityThread.main(ActivityThread.java:3683)
02-11 20:45:43.857: E/AndroidRuntime(338): at java.lang.reflect.Method.invokeNative(Native Method)
02-11 20:45:43.857: E/AndroidRuntime(338): at java.lang.reflect.Method.invoke(Method.java:507)
02-11 20:45:43.857: E/AndroidRuntime(338): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
02-11 20:45:43.857: E/AndroidRuntime(338): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
02-11 20:45:43.857: E/AndroidRuntime(338): at dalvik.system.NativeStart.main(Native Method)
In your stop() method you access the mp variable. However, the mp variable is null until you press play (and the play() method is called). So when you try to access the null variable a NullPointerException is thrown.
A very simple way to stop the NullPointerException is to do something like this:
private void pause() {
if(mp!=null) mp.pause();
}
private void stop() {
if(mp!=null) mp.stop();
}
Of course this solution doesn't account for cases where pause or stop is called twice. Take a look at the MediaPlayer documentation for more info on state management.