Write a method lastNameFirst that takes a string containing a name such as "Harry Smith" or "Mary Jane Lee", and that returns the string with the last name first, such as "Smith, Harry" or "Lee, Mary Jane".
im supposed to check it against
http://wiley.code-check.org/codecheck/files?repo=bjlo2&problem=05_02
i post this
String firstName = name.substring(0, name.indexOf(" "));
String lastName = name.substring(name.indexOf(" "));
String cName = lastName + ", " + firstName;
if ( lastName == " " )
{
cName = firstName;
}
return cName;
I get 0/4 everytime please help im completely lost.
It might be simpler to create an array using the split function of the String class, then join them:
String cName = String.join(", ", Collections.reverse(Arrays.asList(name.split(" "))));
String.join is only in Java 8 I believe, if you're not using 8 you can use something like the following:
String[] names = name.split(" ");
String cName = names[1] + ", " + names[0];
You should also be using the equals method for comparing String and other objects:
String[] names = name.split(" ");
String cName = names[1].equals(" ") ? names[0] : names[1] + ", " + names[0];
Please try this code
String first = name.substring(name.lastIndexOf(" "));
String last = name.substring(0, name.lastIndexOf(" "));
String result = first + "," + last;
Your solution is very close. Here's 2 hints to get to the right solution:
What separates the first and last name is the last, not the first space (consider using str.lastIndexOf(" ")).
As mentioned in the comments, when comparing strings, you can't use str1 == str2, you have to use str1.equals(str2)
You only need the last space in your name, which you can get with String.lastIndexOf(int). Then you test if that is less then 0, if so return the input name. Otherwise, concatenate and return your name in the desired format. Using a ternary (or conditional operator ? :) that might look something like,
int p = name.lastIndexOf(' ');
return (p < 0) ? name : name.substring(p + 1) + ", " + name.substring(0, p);
I put this for that Question and it passed all 4 tests they had.
public static String lastNameFirst(String name)
{
String LastToFirst = "";
if(!name.contains(" ")){
return name;
}
int index = name.indexOf(" ");
int secondIndex = name.indexOf(" ", index + 1);
// exclusive of last index
if(secondIndex != -1) {
LastToFirst += name.substring(secondIndex+1,name.length())+", ";
LastToFirst += name.substring(0,secondIndex);
}
else {
LastToFirst += name.substring(index +1,name.length()) + ", ";
LastToFirst += name.substring(0, index);
return LastToFirst;
}
A better solution for this would be to use an array, and store the characters in there and for the spacing one should add an index variable for where you want the splitting to happen- the string of interest. The solutions above do a good example of expalining this better, they consider cases where it is not a white space, but other symbols making the method more robust. Hope this helps.
I tried this code and all the four arguement works. Hope this helps!!
{
String[] names = name.split(" ");
String cName = "";
if(names.length > 2){
cName = names[2].equals(" ") ? names[0] : names[2] + ", " + names[0] + " " + names[1];
}
else if(names.length == 1){
cName = names[0]
}
else{
cName = names[1].equals(" ") ? names[0] : names[1] + ", " + names[0];
}
return cName;
}
}
public class Names
{
/**
Changes a name so that the last name comes first.
#param name a name such as "Mary Jane Lee"
#return the reversed name, such as "Lee, Mary Jane".
If name has no spaces, it is returned without change.
*/
public static String lastNameFirst(String name)
{
String result = "";
if(!name.contains(" "))
{
String firstOnly = name.substring(0);
return firstOnly;
}
else
{
String first = name.substring(name.lastIndexOf(" ")+1);
String last = name.substring(0, name.lastIndexOf(" "));
result = first + ", " + last;
return result;
}
}
}
This is the correct answer that will get you 4/4.
Related
(In Java) Write a program that accepts names and formats them as follows: If the input is:
John Anthony Brown
Then the output must be:
Brown, John A.
Here is what I have
int mn;
String input3;
int fn;
int ln;
String firstName;
String lastName;
String middleName;
Scanner scnr = new Scanner(System.in);
String input = scnr.nextLine();
fn = input.indexOf(" ");
firstName = input.substring(0, fn);
middleName = input.substring(fn+1, input.length());
mn = middleName.indexOf(" ");
lastName = input.substring(mn+1, input.length());
System.out.println(lastName + ", " + mn + " " + firstName + ".");
}
I keep trying different things and get weird outputs such as "ry A Lee, 1 Mary." for the input "Marry A Lee"
This topic was never covered in my class and I am very confused.
Because this is homework, I’ll give code fragments:
Firstly, use split() to break up the text into words:
String[] names = input.split(" ");
Then build up your result:
String result = names[2] + ", " + names[0] + ", " + names[1].charAt(0) + ".";
There are more elegant ways of doing it, but this way is arguably the easiest to understand.
You could get fancier by catering for varying numbers of names.
Try something like this:
String[] items = input.split(" ");
//if there are three item in items, then it is the pattern you mentioned
if (items.length == 3) {
System.out.println(items[2] + "," + items[0] + items[1].charAt(0) + ".");
}
int lastSpace = fullName.lastIndexOf(" ");
here all the code
import java.util.Scanner;
public class java_13 {
public static void main(String[] args) {
Scanner input = new Scanner(System.in);
System.out.println("Enter your full name");
String fullName = input.nextLine();
int firstSpace = fullName.indexOf(" ");
String firstName = fullName.substring(0, firstSpace);
int lastSpace = fullName.lastIndexOf(" ");
String lastName = fullName.substring(lastSpace + 1);
System.out.println("\n" + lastName + ", " + firstName);
also why we use ( +1 )
here
String lastName = fullName.substring(lastSpace + 1);
Because the space divides firstName and lastName.
The input is supposed to look like "firstName lastName". If you take the position of the " " space from it, then the "lastName" part begins on the next character, hence the +1 to the position for getting the substring.
In Java, the index starts with 0.
For example :
String name = "Moataz Mohamed";
name[0]='M';
name[1]='o';
...
name[6]=' '; //Space
Space separates First name and Last name.
Hence,
0 to index[" "]-1 is First name
index[" "]+1 to length() is Second name
Hope its clear now.
Here the full name is composed of a first name and the last name, this code search the first blank space in order to separate the first name from the last name
But I recommend allowing the user to enter both of the last and the first name instead of the full name because it is impossible to know how much words compose the first name and the same thing for the last name.
As #0x01 mentioned, you get the index of the space, but in last name is beginning at position with index +1, that is the reason, just check this outputs
{...}
public static final String NAME1 = "Julian Papadopulos";
public static final String NAME2 = "John von Bahnhof";
public static final char SPLITCHAR = ' ';
{...}
public static void splitNamesBySpaceIndex() {
// name1
int firstSpace = NAME1.indexOf(" ");
int lastSpace = NAME1.lastIndexOf(" ");
String firstName = NAME1.substring(0, firstSpace);
String lastName = NAME1.substring(lastSpace + 1);
System.out.println("lastname: \'" + lastName + "\', firstname: \'" + firstName + "\'");
lastName = NAME1.substring(lastSpace);
System.out.println("lastname: \'" + lastName + "\', firstname: \'" + firstName + "\'");
}
Output looks like:
lastname: 'Papadopulos', firstname: 'Julian'
lastname: ' Papadopulos', firstname: 'Julian'
As you can see, in the second case you will parse last name like ' Papadopulos', which is not correct, its caused by taking start index the index of the space- this is the reason, why you need position with index +1.
This is like this...
FIRSTNAME LASTNAME
012345678901234567
FIRSTNAME Starts from 0
Index of " " is 9
LASTNAME Starts from 10
That is why you need to add (+1) here
indexOf(" ") {9} but you have to start with LASTNAME which is at 10
If you do not add (+1) then Output will be " LASTNAME"
this is my code
//Numbers (Need errors on sort and numbers)
if(line.contains("n"))
{
//split the line with space
String[] LineSplit = line.split(" ");
if(LineSplit[0].contains("n"))
{
//split the already split line with "n thename "
String[] LineSplit2 = line.split("n " + LineSplit[0] + " ");
String text = "var " + LineSplit[1] + "=" + LineSplit2[0] + ";";
text = text.replace("\n", "").replace("\r", "");
JAVASCRIPTTextToWrite += text;
}
}
the line of text is
n number 1
the output should be
var number = 1;
but the output is
var number=n number = 1;
can some one please tell me how to fix this? the code looks right but doesn't work :(
String line = "n number 1";
String JAVASCRIPTTextToWrite="";
if(line.contains("n"))
{
//split the line with space
String[] LineSplit = line.split(" ");
if(LineSplit[0].contains("n"))
{
//split the already split line with "n thename "
String[] LineSplit2 = line.split("n " + LineSplit[1] + " ");
System.out.println( LineSplit[1]);
System.out.println( LineSplit2[0]);
String text = "var " + LineSplit[1] + "=" + LineSplit2[1] + ";";
text = text.replace("\n", "").replace("\r", "");
JAVASCRIPTTextToWrite += text;
System.out.println(JAVASCRIPTTextToWrite);
}
}
String number = "n number 1";
Sting[] temp = number.split(" ");
StringBuilder sb = new StringBuilder("var ");
sb.append(temp[1]);
sb.append(temp[2]);
perform this operation if your condition satisfied
String line = "n number 1";
if(line.contains("n"))
{
//split the line with space
String[] LineSplit = line.split(" ");
if(LineSplit[0].contains("n")) {
//split the already split line with "n thename "
String LineSplit2 = line.substring(line.lastIndexOf(" ") + 1 , line.length());
String text = "var " + LineSplit[1] + "=" + LineSplit2 + ";";
//text = text.replace("\n", "").replace("\r", "");
System.out.println(text);
}
}
Output:
var number=1;
I do not know what is your purpose for split the string twice. Just for the out put you want, I think the solution below is enough. Please look at the code below whether is you want:
String line = "n number 1";
String JAVASCRIPTTextToWrite = "";
//Numbers (Need errors on sort and numbers)
if(line.contains("n")) {
//split the line with space
String[] LineSplit = line.split(" ");
if(LineSplit.length == 3) {
StringBuilder text = new StringBuilder();
text.append("var ");
text.append(LineSplit[1]);
text.append("=");
text.append(LineSplit[2]);
text.append(";");
JAVASCRIPTTextToWrite += text.toString().replace("\n", "").replace("\r", "");
System.out.println(JAVASCRIPTTextToWrite);
}
}
Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.
Questions concerning problems with code you've written must describe the specific problem — and include valid code to reproduce it — in the question itself. See SSCCE.org for guidance.
Closed 9 years ago.
Improve this question
I have tried so many variations of this code and I can't seem to get it correct.
I get an array out of bounds issue for the second if statement if I try something only with two parts. However, it works fine if there are 3 parts in the name.
import java.util.Scanner;
public class testArray
{
public static void main(String[]args)
{
Scanner input = new Scanner(System.in);
String fullName = input.nextLine();
fullName = fullName + " " + " ";
System.out.println(fullName);
String [] parts = fullName.split(" ");
String firstName = parts[0];
String middleName = parts[1];
String lastName = parts[2];
String firstNameInitial = firstName.substring(0,1).toUpperCase(); //capitalizes first initial
String middleNameInitial = middleName.substring(0,1).toUpperCase(); //capitalizes second initial
String lastNameInitial = lastName.substring(0,1).toUpperCase(); //capitalizes third initial
String initials = firstNameInitial + middleNameInitial + lastNameInitial; //Combines initials of name in capital form
if (parts.length == 3)
{
System.out.println(initials);
System.out.println(lastName.toUpperCase() + ", " + firstNameInitial+firstName.substring(1,parts[0].length()) + " " + lastNameInitial + ".");
System.out.println(lastNameInitial + lastName.substring(1,parts[2].length()) + ", " + firstNameInitial+firstName.substring(1,parts[0].length()) + " " + middleNameInitial + middleName.substring(1,parts[1].length()));
}
if (parts.length == 2)
{
System.out.println("error");
}
}
}
That's because the way you initialize your variables:
String firstName = parts[0];
String middleName = parts[1];
String lastName = parts[2];
Here, if parts only has index 0 and 1 (a length of 2) you will get an exception because there is no parts[2] (it's index is out of bounds).
Modify that to something like this:
String firstName = parts[0];
String middleName = null;
String lastName = parts[1];
if (parts.length > 2) {
middleName = parts[1];
lastName = parts[2];
}
With this code, middleName will only be set if parts has a length greater than 2, which means that the index 2 will exist. Otherwise, middleName will be null (or you could change this to be an empty string or whatever you would like)
You are trying to access the 3rd object in the array before you check how long the array is.
try this instead:
import java.util.Scanner;
public class testArray
{
public static void main(String[]args)
{
Scanner input = new Scanner(System.in);
String fullName = input.nextLine();
fullName = fullName + " " + " ";
System.out.println(fullName);
String [] parts = fullName.split(" ");
if(parts.length == 3)
{
String firstName = parts[0];
String middleName = parts[1];
String lastName = parts[2];
String firstNameInitial = firstName.substring(0,1).toUpperCase(); //capitalizes first initial
String middleNameInitial = middleName.substring(0,1).toUpperCase(); //capitalizes second initial
String lastNameInitial = lastName.substring(0,1).toUpperCase(); //capitalizes third initial
String initials = firstNameInitial + middleNameInitial + lastNameInitial; //Combines initials of name in capital form
System.out.println(initials);
System.out.println(lastName.toUpperCase() + ", " + firstNameInitial+firstName.substring(1,parts[0].length()) + " " + lastNameInitial + ".");
System.out.println(lastNameInitial + lastName.substring(1,parts[2].length()) + ", " + firstNameInitial+firstName.substring(1,parts[0].length()) + " " + middleNameInitial + middleName.substring(1,parts[1].length()));
}else{
System.out.println("error");
}
}
}
i think these line you want to put just after calling split:
String [] parts = fullName.split(" ");
if (parts.length == 2)
{
System.out.println("error");
return;
}
so the code would look like:
public static void main(String[]args) {
Scanner input = new Scanner(System.in);
String fullName = input.nextLine();
fullName = fullName + " " + " ";
System.out.println(fullName);
String [] parts = fullName.split(" ");
if (parts.length == 2)
{
System.out.println("error");
} else if(parts.length == 3) {
String firstName = parts[0];
String middleName = parts[1];
String lastName = parts[2];
String firstNameInitial = firstName.substring(0,1).toUpperCase(); //capitalizes first initial
String middleNameInitial = middleName.substring(0,1).toUpperCase(); //capitalizes second initial
String lastNameInitial = lastName.substring(0,1).toUpperCase(); //capitalizes third initial
String initials = firstNameInitial + middleNameInitial + lastNameInitial; //Combines initials of name in capital form
System.out.println(initials);
System.out.println(lastName.toUpperCase() + ", " + firstNameInitial+firstName.substring(1,parts[0].length()) + " " + lastNameInitial + ".");
System.out.println(lastNameInitial + lastName.substring(1,parts[2].length()) + ", " + firstNameInitial+firstName.substring(1,parts[0].length()) + " " + middleNameInitial + middleName.substring(1,parts[1].length()));
}
}
i might suggest splitting on white space rather that " "
so for example
String [] parts = fullName.split("\\s+");
also why are you adding spaces (fullName = fullName + " " + " ";)
also you might not get to your parts comparison because you will hit the String extraction from the array first, put your if check (if(parts.length == 3)) straight after the splitting (String [] parts = fullName.split("\\s+");)
The error comes from here:
Scanner input = new Scanner(System.in);
String fullName = input.nextLine();
fullName = fullName + " " + " ";
System.out.println(fullName);
String [] parts = fullName.split(" ");
String firstName = parts[0];
String middleName = parts[1];
String lastName = parts[2];
If someone enters text that is less than 3 words long, you get an ArrayIndexOutOfBoundsException. You have to add something like:
Scanner input = new Scanner(System.in);
String [] parts = null;
while (input.hasNext()) {
System.out.println("Please enter first middle and last name");
String fullName = input.nextLine();
fullName = fullName + " " + " ";
System.out.println(fullName);
parts = fullName.split(" ");
if (parts.length == 3)
break;
}
String firstName = parts[0];
String middleName = parts[1];
String lastName = parts[2];
Which will prompt the user for three words until you get the right amount.
Issue is here
String middleName = parts[1];
String lastName = parts[2];
You are appending two white spaces for fullName fullName = fullName + " " + " "; but actually these spaces won't append as there is no text after fullName, hence parts consists only one element at 0 position. and you are calling 1st position of parts array which is not available String middleName = parts[1]; So you are seeing ArrayIndexOutOfBoundsException
0,1,2,3,4 >> these are indexed till 4 but the total components or length is 5 .
So In
firstName.substring(1,parts[0].length())
Here, "parts[0].length()" should be replaced by "parts[0].length()-1" because the previous is increasing the size by 1 and hence array is out of bound..
The same error u will get in next line.
So replace every .length with .length-1 ..
And remove this line
fullName = fullName + " " + " "; because it increases the length of variable path to 5 and hence it dosent goes in the if statements
Ok, so it's the first time I am posting out here, so bear with me.
I have a name in the format of "Smith, Bob I" and I need to switch this string around to read "Bob I. Smith". Any ideas on how to go about doing this?
This is one way that I've tried, and while it does get the job done, It looks pretty sloppy.
public static void main(String[] args) {
String s = "Smith, Bob I.", r = "";
String[] names;
for(int i =0; i < s.length(); i++){
if(s.indexOf(',') != -1){
if(s.charAt(i) != ',')
r += s.charAt(i);
}
}
names = r.split(" ");
for(int i = 0; i < names.length; i++){
}
System.out.println(names[1] +" " + names[2] + " " + names[0]);
}
If the name is always <last name>, <firstname>, try this:
String name = "Smith, Bob I.".replaceAll( "(.*),\\s+(.*)", "$2 $1" );
This will collect Smith into group 1 and Bob I. into group 2, which then are accessed as $1 and $2 in the replacement string. Due to the (.*) groups in the expression the entire string matches and will be replaced completely by the replacement, which is just the 2 groups swapped and separated by a space character.
String[] names = "Smith, Bob I.".split("[, ]+");
System.out.println(names[1] + " " + names[2] + " " + names[0]);
final String[] s = "Smith, Bob I.".split(",");
System.out.println(String.format("%s %s", s[1].trim(), s[0]));
String s = "Smith, Bob I.";
String result = s.substring(s.indexOf(" ")).trim() + " "
+ s.substring(0, s.indexOf(","));