We Keep Coding

Sqlite databse puts data in the wrong columns

I'm having a problem with my database when I try to add data from the simulator it puts it in the wrong column. I understand that it begins from 0 like (1 column = 0, 2 column = 1....)
I think I set it to 1 to put the data in the 2 columns but instead it puts it in the 3 columns but when set it to "0" it adds data the first column like it supposed to. Anybody has any ideas why it might be happening?
package com.example.laivumusis;
import android.database.Cursor;
import android.os.Bundle;
import android.widget.ArrayAdapter;
import android.widget.ListAdapter;
import android.widget.ListView;
import android.widget.Toast;
import androidx.annotation.Nullable;
import androidx.appcompat.app.AppCompatActivity;
import java.util.ArrayList;
public class ViewListData extends AppCompatActivity {
KlausimynoDatabaseHelper myDB;
#Override
protected void onCreate(#Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.editlistview_layout);
ListView listView = (ListView) findViewById(R.id.listView);
myDB = new KlausimynoDatabaseHelper(this);
ArrayList<String> theList = new ArrayList<>();
Cursor data = myDB.getListContents();
if (data.getCount() == 0) {
Toast.makeText(ViewListData.this,"Database tuščias!",Toast.LENGTH_LONG).show();
}else{
while (data.moveToNext()){
theList.add(data.getString(1));
ListAdapter listAdapter = new ArrayAdapter<>(this, android.R.layout.simple_list_item_1,theList);
listView.setAdapter(listAdapter);
}
}
}
}

Don't use the index of the column like this:
theList.add(data.getString(1));
Use the method getColumnIndex() by passing the name of the column, because the order of the columns may not be what you think it is.
So change to this:
theList.add(data.getString(data.getColumnIndex("columnName")));
Replace columnName with the name of the column that you want.

Android cursor problems "Make sure the Cursor is initialized correctly before accessing data from it."

java.lang.IllegalStateException: Couldn't read row 0, col -1 from CursorWindow. Make sure the Cursor is initialized correctly before accessing data from it.
I want to get the photo name from SQL database,then get the photo from drawable file and link the photo to a ImageView item which is inside a ListView what is the problem with following code, Please help me fix it, thank you
import android.app.ListActivity;
import android.content.Intent;
import android.content.res.Resources;
import android.database.Cursor;
import android.database.sqlite.SQLiteDatabase;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.util.Log;
import android.view.View;
import android.widget.ImageView;
import android.widget.ListView;
import android.widget.SimpleCursorAdapter;
import android.widget.TextView;
public class HotProduct extends ListActivity {
private ProductSQLiteHelper sqlHelper;
private SQLiteDatabase infodb;
private String[] columnsToSelect;
private String[] columnsToSelect2;
private Cursor infoCursor;
private SimpleCursorAdapter dbAdapter;
private SimpleCursorAdapter dbAdapter2;
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.hotproduct_middle_page);
columnsToSelect = new String[] {
ProductSQLiteHelper.PRODUCT_ID,
ProductSQLiteHelper.PRODUCT_NAME,
ProductSQLiteHelper.PRODUCT_BRAND,
ProductSQLiteHelper.PRODUCT_PRICE
};
Resources res = getResources();
Log.v("Res:",String.valueOf(res));
// setTitle("Hot Product");
sqlHelper = new ProductSQLiteHelper(this);
infodb = sqlHelper.getReadableDatabase();
Cursor infoCursor= infodb.rawQuery("SELECT photo FROM phone", null);
ImageView moviePoster = (ImageView) findViewById(R.id.productPhoto);
infoCursor.moveToFirst();
if (!infoCursor.isAfterLast()) {
if (infoCursor.getInt(infoCursor.getColumnIndex(String.valueOf(ProductSQLiteHelper.PRODUCT_HOT))) == 1) {
res = this.getResources();
String posterResourceName = infoCursor.getString(infoCursor.getColumnIndex(ProductSQLiteHelper.PRODUCT_PHOTO));
Log.v("resource name",posterResourceName);
int resId = res.getIdentifier(posterResourceName, "drawable", getPackageName());
moviePoster.setImageResource(resId);
}
}
String columnsToDisplay[] = {
ProductSQLiteHelper.PRODUCT_NAME,
ProductSQLiteHelper.PRODUCT_BRAND,
ProductSQLiteHelper.PRODUCT_PRICE
// ProductSQLiteHelper.PRODUCT_PHOTO
};
int mappingToView[] = {
R.id.productName,
R.id.productBrand,
R.id.productPrice
// R.id.productPhoto
};
String args[] = {"1"};
infoCursor = infodb.query(ProductSQLiteHelper.TABLE_NAME,columnsToSelect," hot = ? ",args,null,null,null);
String posterResourceName = infoCursor.getString(infoCursor.getColumnIndex("photo"));
Log.v("resource name",posterResourceName);
dbAdapter = new SimpleCursorAdapter(this,R.layout.hotproduct_middle_page_row,infoCursor,columnsToDisplay,mappingToView,0);
setListAdapter(dbAdapter);
}
}
I found that the problems appear in
Cursor infoCursor= infodb.rawQuery("SELECT photo FROM phone", null);
ImageView moviePoster = (ImageView) findViewById(R.id.productPhoto);
infoCursor.moveToFirst();
if (!infoCursor.isAfterLast()) {
if (infoCursor.getInt(infoCursor.getColumnIndex(String.valueOf(ProductSQLiteHelper.PRODUCT_HOT))) == 1) {
res = this.getResources();
String posterResourceName = infoCursor.getString(infoCursor.getColumnIndex(ProductSQLiteHelper.PRODUCT_PHOTO));
Log.v("resource name",posterResourceName);
int resId = res.getIdentifier(posterResourceName, "drawable", getPackageName());
moviePoster.setImageResource(resId);
}
}

Your issue is due to a getColumnIndex not finding the specified column and thus returning -1 (as it does when the column is not a column). The underlying cause is that you are creating a Cursor with a single column yet in your code you are trying to access 2 columns i.e.
infoCursor.getInt(infoCursor.getColumnIndex(String.valueOf(ProductSQLiteHelper.PRODUCT_HOT)))
infoCursor.getString(infoCursor.getColumnIndex(ProductSQLiteHelper.PRODUCT_PHOTO))
The Cursor will contain just 1 column, the photo column.
I would suggest changing the SELECT clause to "SELECT * FROM phone", this will then create a Cursor with ALL columns from the table.
However, there is an additional flaw with the code in that you are not checking the result of the moveToFirst.
If the Cursor is empty then moveToFirst will return false. As the Cursor will not be after the last any attempt to retrieve data from the Cursor will fail as there is no data.
I would suggest amending your code to :-
Cursor infoCursor= infodb.rawQuery("SELECT * FROM phone", null);
ImageView moviePoster = (ImageView) findViewById(R.id.productPhoto);
while (infoCursor.moveToNext()) {
if (infoCursor.getInt(infoCursor.getColumnIndex(String.valueOf(ProductSQLiteHelper.PRODUCT_HOT))) == 1) {
res = this.getResources();
String posterResourceName = infoCursor.getString(infoCursor.getColumnIndex(ProductSQLiteHelper.PRODUCT_PHOTO));
Log.v("resource name",posterResourceName);
int resId = res.getIdentifier(posterResourceName, "drawable", getPackageName());
moviePoster.setImageResource(resId);
}
}
You may have to write code to handle an empty cursor.

how to display listview items, when a user enter some number in textbox?

how to display listview items in android, when a user enter some number in edittext and click on a button to display the specified number of list items on the next activity ?
I have one EditText and a Button on MainActivity1 and a ListView and TextView on MainActivity2. TextView is just for letting me know tht value is passing on next screen.
MainActivity.java
package com.populatelist;
import android.support.v7.app.ActionBarActivity;
import android.content.Intent;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import android.widget.EditText;
public class MainActivity extends ActionBarActivity {
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
final EditText edt = (EditText)findViewById(R.id.editText1);
Button btn = (Button)findViewById(R.id.button1);
btn.setOnClickListener(new View.OnClickListener() {
#Override
public void onClick(View v) {
Intent myin = new Intent(MainActivity.this,MainActivity2.class);
myin.putExtra("textbox", edt.getText().toString());
startActivity(myin);
}
});
}
}
MainActivity2.java
package com.populatelist;
import android.support.v7.app.ActionBarActivity;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import android.content.Intent;
import android.os.Bundle;
import android.view.Menu;
import android.view.MenuItem;
import android.widget.ArrayAdapter;
import android.widget.Button;
import android.widget.ListView;
import android.widget.TextView;
public class MainActivity2 extends ActionBarActivity {
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main_activity2);
TextView tv = (TextView)findViewById(R.id.textView1);
Intent myin2 = getIntent();
String str = myin2.getStringExtra("textbox");
tv.setText(str);
final ListView lv = (ListView) findViewById(R.id.listView1);
String[] arrStr = new String[] {
"Hello World",
"Hello India",
"Hello Rajasthan",
"Hello Jodhpur",
"Hello Mujeeb"
};
final List<String> hello_list = new ArrayList<String>(Arrays.asList(arrStr));
final ArrayAdapter<String> arrayAdapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, hello_list);
int n = Integer.parseInt(str);
lv.setAdapter(arrayAdapter);
}
}

You can simply add the coming value at last of your string array like
String[] arrStr = new String[] {
"Hello World",
"Hello India",
"Hello Rajasthan",
"Hello Jodhpur",
"Hello Mujeeb",
str
};
It will show your input value to last position of your listview.
And if you want to add new items and show old as well then you have to pass whole string array to previous activity and add new value to last position, pass it when start next activity. By using this you can see all data on listview.

Whenever you get value in second activity create a new array "b" with required no of values.
String str = myin2.getStringExtra("textbox");
int noOfNames = Integer.parseInt(str);
String[] b = new String[StringnoOfNames];
Then copy the items from the original array
b = Arrays.copyOf(arrStr, noOfNames);
final List<String> hello_list = new ArrayList<String>(Arrays.asList(b));

First, validate if your EditText isn't null, here your app may crash
if (edt.getText().length() > 0) {
Intent myin = new Intent(MainActivity.this,MainActivity2.class);
myin.putExtra("textbox", Integer.parseInt(edt.getText().toString()));
startActivity(myin);
}
Then handle your intent
ListView lv = (ListView) findViewById(R.id.listview1);
ArrayAdapter<String> arrayAdapter = null;
int number = intent.getIntExtra("textbox", 0);
switch (number) {
case 0:
arrayAdapter = new ArrayAdapter<String>(context, android.R.layout.simple_list_item_1, arrStr);
lv.setAdapter(arrayAdapter);
arrayAdapter.notifyDataSetChanged();
break;
case 1:
arrayAdapter = new ArrayAdapter<String>(context, android.R.layout.simple_list_item_1, AnotherSourceArray);
lv.setAdapter(arrayAdapter);
arrayAdapter.notifyDataSetChanged();
break;
case 2:
arrayAdapter = new ArrayAdapter<String>(context, android.R.layout.simple_list_item_1, AnotherSourceArray);
lv.setAdapter(arrayAdapter);
arrayAdapter.notifyDataSetChanged();
break;
...
default:
break;
}
Note - this is just sample. You can resolve this on many another ways. Each switch case may contain another data to display. Using default layouts for listviews may be frustrating, better way is to create custom class which extends ArrayAdapter<String>

null pointer in listview

i have a listview which will retrieve detail and date from database. now im going add one textfield inside the listview. The textfield is for me to compare the date from database and count the remain day. First, i try to get the current the date to test whether can show the date in the listview or nt and i fail to show it.
package my.com.chyi.schedulev2;
import android.app.Activity;
import android.app.Activity;
import android.content.Intent;
import android.database.Cursor;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.AdapterView;
import android.widget.AdapterView.OnItemClickListener;
import android.widget.Button;
import android.widget.ListView;
import android.widget.SimpleCursorAdapter;
import android.widget.TextView;
import java.text.SimpleDateFormat;
import java.util.Calendar;
import my.com.chyi.schedulev2.SQLController;
/**
* Created by chyi1_000 on 3/19/2015.
*/
public class assigmentActivity extends Activity {
Button addass_bt;
ListView lv;
SQLController dbcon;
TextView assID_tv,assName_tv,assAtime_tv,assRemain;
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_assign);
dbcon = new SQLController(this);
dbcon.open();
//assign module
addass_bt = (Button)findViewById(R.id.addAss_bt_id);
lv =(ListView)findViewById(R.id.assList_id);
//assig module
addass_bt.setOnClickListener(new OnClickListener() {
#Override
public void onClick(View v) {
Intent add_ass = new Intent(assigmentActivity.this,Add_Assignment.class);
startActivity(add_ass);
}
});
//assig module
Cursor cursor = dbcon.readDataA();
//calculate days different
// list -> loop
// each row different days
String[] fromA = new String[] { DBhelper.ASSIGNMENT_ID,DBhelper.ASSIGNMENT_NAME,DBhelper.ASSIGNMENT_mTime, };
int[] toA = new int[] { R.id.assigment_id, R.id.assigment_name, R.id.assigment_ATime};
SimpleCursorAdapter adapterA = new SimpleCursorAdapter(
assigmentActivity.this, R.layout.view_assignment_entry, cursor, fromA, toA);
adapterA.notifyDataSetChanged();
lv.setAdapter(adapterA);
// assig module
lv.setOnItemClickListener(new OnItemClickListener() {
#Override
public void onItemClick(AdapterView<?> parent, View view,
int position, long id) {
assID_tv = (TextView) view.findViewById(R.id.assigment_id);
assName_tv = (TextView) view.findViewById(R.id.assigment_name);
assAtime_tv = (TextView)view.findViewById(R.id.assigment_ATime);
Calendar d = Calendar.getInstance();
SimpleDateFormat dfd = new SimpleDateFormat("yyyy-MM-dd");
String formattedDateD = dfd.format(d.getTime().toString());
String test = formattedDateD;
String assID_val = assID_tv.getText().toString();
String assName_val = assName_tv.getText().toString();
String assATime_val = assAtime_tv .getText().toString();
Intent modify_intent = new Intent(getApplicationContext(),
Modify_assignment.class);
modify_intent.putExtra("assName", assName_val);
modify_intent.putExtra("assID", assID_val);
modify_intent.putExtra("assAtime",assATime_val);
startActivity(modify_intent);
}
});
TextView babu = (TextView) findViewById(R.id.assigment_remain);
Calendar d = Calendar.getInstance();
SimpleDateFormat dfd = new SimpleDateFormat("yyyy-MM-dd");
String formattedDateD = dfd.format(d.getTime().toString());
babu.setText(formattedDateD);
}
}
i get error at java.lang.NullPointerException at bubu.setText(formattedDateD);
may i know wht is the problem?thank for the help. my listview will auto get all the data from my SQLController, so i cannot add extra textfield in the listview.
public Cursor readDataA(){
String[] allcolumnsA = new String[] { DBhelper.ASSIGNMENT_ID,DBhelper.ASSIGNMENT_NAME,DBhelper.ASSIGNMENT_mTime};
Cursor e = database.query(DBhelper.TABLE_ASSIGNMENT, allcolumnsA,null, null, null, null, null);
if (e != null ) {
e.moveToFirst();
}
return e;
}

Try with "yyyy-MM-dd" as the pattern .

Add one 'M' to your date format

String formattedDateD = dfd.format(d.getTime()).toString();

i get error at java.lang.NullPointerException at bubu.setText(formattedDateD);
This would suggest that bubu (or babu as you have it in your code) is null.
I would take a look at this line:
TextView babu = (TextView) findViewById(R.id.assigment_remain);
This is probably not finding the view and hence returning null.
Your code needs to cope with that case and you also need to track down why you have the wrong id for your view.

SimpleCursorAdapter in android

This is my first time creating android app. and what i want to create now is to make a list and when a user click a name in the list the detail of the click name will show. I am trying to create simple cursor adapter. But an error occur
The constructor SimpleCursorAdapter(QuestionsNew, int, Cursor, String[], int[]) is undefined.
What do you think is the possible reason for this. Below is some part of my code
package tk.wew.wew;
import info.androidhive.sqlite.model.LocalStorage;
import info.androidhive.sqlite.model.Message;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import android.content.Intent;
import android.database.Cursor;
import android.os.Bundle;
import android.support.v4.app.Fragment;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.AdapterView;
import android.widget.ListAdapter;
import android.widget.ListView;
import android.widget.SimpleCursorAdapter;
import android.widget.TextView;
import android.widget.Toast;
import android.widget.AdapterView.OnItemClickListener;
import static tk.askd.askd.CommonUtilities.*;
public class QuestionsNew extends Fragment {
Cursor cursor;
ListView nameList;
protected ListAdapter adapter;
// TextView tvCompany = (TextView)
// findViewById(R.id.tvContactListCompany);
private static final String TAG = "Question";
private ListView list;
private static List questions;
ArrayList<String> senders = new ArrayList<String>();
ArrayList<String> shortMsg = new ArrayList<String>();
ArrayList<Integer> imageId = new ArrayList<Integer>();
SimpleCursorAdapter myCursorAdapter;
#Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
View view;
//CommonUtilities.sendAQuestion(getActivity(), "msg123Kjjj11", "richmund_10023", "lofrancs1231", "Apil ka?");
questions = CommonUtilities.getAllQuestions(getActivity(), "N", null);
if(questions.size() > 0){
view = inflater.inflate(R.layout.questions_main_layout, container, false);
AskdDatabaseHelper msg_db = new AskdDatabaseHelper(getActivity());
List<Message> messages = msg_db.getAllQuestions("N", "lofrancs1231");
Cursor cursor = msg_db.getAllQuestions3();
// Setup mapping from cursor to view fields:
String[] fromFieldNames = new String[] { "KEY_MSG_MESSAGE_ID","KEY_MSG_MESSAGE" };
int[] toViewIDs = new int[] { R.id.KEY_MSG_MESSAGE_ID, R.id.KEY_MSG_MESSAGE_ID };
/* SimpleCursorAdapter myCursorAdapter = new SimpleCursorAdapter(this, // Context
R.layout.message_list_item, // Row layout template
cursor, // cursor (set of DB records to map)
fromFieldNames, // DB Column names
toViewIDs // View IDs to put information in
);*/
myCursorAdapter = new SimpleCursorAdapter(QuestionsNew.this,
R.layout.message_list_item,
cursor,
fromFieldNames,
toViewIDs);
ListView contactList = (ListView) getView().findViewById(R.id.lvContacts);
contactList.setAdapter(myCursorAdapter);
for(int m=0; m<questions.size(); m++){
senders.add(messages.get(m).getFromUser());
shortMsg.add(messages.get(m).getMessage());
imageId.add(R.drawable.ic_launcher);
}
} else {
view = inflater.inflate(R.layout.fragments_question_new, container, false);
((TextView)view.findViewById(R.id.textView)).setText("No New Questions");
}
return view;
}
#Override
public void onStart(){
super.onStart();
Log.v(TAG, ": New onStart");
if(questions.size() > 0){
list = (ListView) getView().findViewById(R.id.list);
CustomLst adapter = new CustomLst(getActivity(), senders, imageId, shortMsg);
list.setAdapter(adapter);
list.setOnItemClickListener(new OnItemClickListener(){
#Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id){
// Cursor listCursor = (Cursor) parent.getItemAtPosition(position);
// Cursor listCursor = (Cursor) parent.getAdapter().getItem(position);
// Log.d("TAG", (String) parent.getItemAtPosition(id));
Toast.makeText(getActivity(),
"Position:"+ parent.getItemIdAtPosition((int) id), Toast.LENGTH_LONG)
.show();
// int message = listCursor.getInt(listCursor.getColumnIndex(AskdDatabaseHelper.KEY_MSG_MESSAGE_ID));
/*
Intent intent = new Intent(getActivity(), QuestionDetail.class);
intent.putExtra("Message_ID", listCursor.getString(listCursor.getColumnIndex(AskdDatabaseHelper.KEY_MSG_MESSAGE_ID)));
startActivity(intent);
// ListView clicked item index
int Position = position;
// ListView clicked item value
String itemValue = (String) list.getItemAtPosition(Position);
// show alert
// Toast.makeText(getActivity(),
// "Position:" + Position + " Listitem:" + itemValue, Toast.LENGTH_LONG)
// .show();
*/
}
});
} else {
Log.e(TAG, "No new question");
}
}
}

Change your constructor as below
myCursorAdapter = new SimpleCursorAdapter(getActivity(),
R.layout.message_list_item,
cursor,
fromFieldNames,
toViewIDs);
The first param is a Context. This QuestionsNew.this is not a valid context. Fragment does not extend Context.
Activity
java.lang.Object
↳ android.content.Context // check this
↳ android.content.ContextWrapper
↳ android.view.ContextThemeWrapper
↳ android.app.Activity // check this
Fragment
java.lang.Object
↳ android.app.Fragment // check this
So get context in fragment use getActivity()
public final Activity getActivity ()
Added in API level 11 Return the Activity this fragment is currently
associated with.
Also
SimpleCursorAdapter(Context context, int layout, Cursor c, String[]
from, int[] to) This constructor was deprecated in API level 11. This
option is discouraged, as it results in Cursor queries being performed
on the application's UI thread and thus can cause poor responsiveness
or even Application Not Responding errors. As an alternative, use
LoaderManager with a CursorLoader.
It is same when you use ArrayAdapter in Fragment class. The first param to the constructor of ArrayAdapter is a valid context. So even in that case you need to use getActivity() instead of FragmentName.this.